Support for <GoogleOneTap/> - #3409
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 3895193 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
force-pushed
the
elef/backport-google-one-tap-to-v4
branch
from
May 21, 2024 10:15
1231228 to
8dfc2f4
Compare
panteliselef
changed the title
<GoogleOneTap/>
panteliselef
marked this pull request as ready for review
May 21, 2024 11:16
anagstef
approved these changes
May 21, 2024
| }) | ||
| .catch(err => { | ||
| if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') { | ||
| return this.client?.signUp.create({ |
Contributor
There was a problem hiding this comment.
@panteliselef I think I've mentioned this before, but I'm double-checking that this signUp.create will trigger a Captcha functionality, and if the user has selected the "Smart" option it will try to find the clerk-captcha in the DOM. Thankfully, it won't break, because we fallback to "Invisible", but the fallback mechanism may change in the future, we should not depend on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR backports into Core 1
<GoogleOneTap/>#3250Checklist
npm testruns as expected.npm run buildruns as expected.Type of change